Revert "Readd root/admin user detection" #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45c4f90.
aurorasmiles
approved these changes
Oct 2, 2021
|
Serious question: Has the detection on pterodactyl been inconsistent (some hosts this works as tested, others give unexpected results)? I have access to at least a dozen p-instances through various customers (people I help), anything I can do to help test this maybe? I can try to reach out to a bunch of them. |
|
@mrfloris we have identified the issue to be a bug in Java and were able to reproduce it consistently. There's a new PR with workaround for this bug - if you want to help make sure it covers everything, testing it would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6593
This trips the detection on many pterodactyl-based hosts despite them setting a user correctly. Reverted until further investigation can be done
Further investigation has now been conducted, more information can be found here: https://bugs.openjdk.java.net/browse/JDK-8274721