Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node version to 18.x for ci #192

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

chouchouji
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: abc9fa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chouchouji
Copy link
Contributor Author

@iosh I increase the node version of ci.

@iosh
Copy link
Collaborator

iosh commented Nov 21, 2024

Hi can you update actions/setup-node and actions/checkout ?

@chouchouji
Copy link
Contributor Author

actions/setup-node

I check the version of them

image

Do you mean that I should change v3 to v4?

image

@iosh
Copy link
Collaborator

iosh commented Nov 21, 2024

Yes.

@chouchouji
Copy link
Contributor Author

Yes.

done

Copy link
Collaborator

@iosh iosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chouchouji .

@iosh iosh merged commit 82c79b2 into Pana:master Nov 21, 2024
2 checks passed
@chouchouji chouchouji deleted the chore-ci branch November 21, 2024 08:10
@chouchouji
Copy link
Contributor Author

If the #191 is merged, the lowest node version should be 18.x. We have increased the node version to 18.x in ci. I think it is good to add engine to package.json and update readme.md.

@chouchouji
Copy link
Contributor Author

If the #191 is merged, the lowest node version should be 18.x. We have increased the node version to 18.x in ci. I think it is good to add engine to package.json and update readme.md.

I think I can add this changes to #191. What do you think? @iosh

@iosh
Copy link
Collaborator

iosh commented Nov 21, 2024

If the #191 is merged, the lowest node version should be 18.x. We have increased the node version to 18.x in ci. I think it is good to add engine to package.json and update readme.md.

I think I can add this changes to #191. What do you think? @iosh

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants