optimize loki #146
Merged
optimize loki #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The timeout change was already done. |
Merged
|
I missed that you had set the destination of the merge to 'master' so I had to revert it again. Please remake the pull request to 'next'. |
|
I will do it. For loki, we may need some other updates to disable some labels. Loki has a limitation that the labels should not change too much. So we need to disable some labels like timestamp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) set timeout to http_maxtime in https.request2, which can be compatible with https.request.
(2) update the logserver format to remove single quotes. Because with bash command arguments, the single quotes are not easy to be passed to the variables.
(3) update loki handler, to remove to items. In the new tests, it seems the loki server limits the number of labels. Here we publish too many labels which are not useful. So I removed these labels.