3.7.0.36

[PalNilsson]

• Added verification of exception thrown during payload error interpretation
  • Previously, a FileHandlingFailure exception thrown during payload error interpretation would lead to a crash
  • Also, now verifying that payload stdout/err actually exists before trying to read it
  • Reported by Z. Yang (Rubin)
• Added xroot client log file to log if it exists
  • Adding ‘XRD_LOGLEVEL=Dump XRD_LOGFILE=xrdlog.txt’ to PQ.environ causes the wrapper to set these env vars, and the pilot also adds them to the payload command. Upon a file transfer, the variables (if set) trigger the xroot client to create a log file that is stored in the pilot’s launch directory
  • There is one file per file transfer, and the pilot renames them to xrdlog-<LFN|payload>.txt (but using the file name pattern from XRD_LOGFILE). They are then copied to the tar directory (the corresponding log file for the job log transfer will of course be missed)
  • Requested by R. Walker
• Aborting pilot immediately after server instruction ‘tobekilled’
  • The job monitor can otherwise get stuck in a loop that can take some time to get out of
• The core dump produced by the pilot when a looping payload process has been detected, is now created for the youngest child process rather than the main payload process
• Extended panda secrets usage for logging into docker (for user container)
  • Any secrets are redacted in logs
  • Requested by R. Zhang
• Housekeeping
  • Corrected all module headers for Apache license 2.0 so they pass the updated apache-license-check
  • Several pilot modules (10%) now pass the pydocstyle test
  • Pilot module was processed with the black tool
  • Some minor linting was done using pylint - currently around 30% of the pilot modules have a score of over 9 out of 10
  • The plan is to process all modules with these commands and eventually use them with local pre-commit and remote GitHub Actions that run after a PR