Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: For PR make prefix shorten by 1 letter #10

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

sebastianczech
Copy link
Contributor

Description

PR delivers fix for AWS VM-Series modules as for some resources in AWS examples names cannot be longer than 32 characters.

Motivation and Context

Issue with names longer than 32 was detected while doing https://github.com/PaloAltoNetworks/terraform-aws-vmseries-modules/actions/runs/6221685571

How Has This Been Tested?

Code was tested on local machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

…examples names cannot be longer than 32 characters
Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sebastianczech sebastianczech merged commit fbc93aa into main Sep 18, 2023
2 checks passed
@sebastianczech sebastianczech deleted the shorten-prefix-aws branch September 18, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants