This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
refactor(module/loadbalancer): separate fip and rules #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me it's cleaner approach, we don't have so much locals, validations can be splited into separated variables etc. :) |
|
Hey Łukasz, are you still planning to prepare more complex examples to compare old vs new way of doing things? |
Base automatically changed from
329-load-balancer-refactor
to
307-refactor-modules
November 16, 2023 12:42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example how separation of FIPs and rules would look like