Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

fix(module/vmseries): fix destroy sequence for LB backends #246

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Mar 21, 2023

Description

For destroy operations, force the LB backend association to be destroyed 1st.

Motivation and Context

W/o that manual dependency, during destroy operations, a race condition can happen, when VM is being destroyed before the NIC - LB backend association. In such case the destroy operation fails with an error. The problem is not the order but the fact that the VM is in a 'destroying' phase while the the destroy operation is run on the association.

This fix can also close #199 as the problem described in that issue is triggered only when a destroy operation 1st fails due to the described race condition.

How Has This Been Tested?

Existing code/example have been run to prove that the race condition cannot be reproduced.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@FoSix FoSix requested a review from a team as a code owner March 21, 2023 13:58
@FoSix FoSix merged commit d7f7116 into main Mar 22, 2023
@FoSix FoSix deleted the vmseries-destroy-dependencies-fix branch March 22, 2023 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Destroy errors
2 participants