-
Notifications
You must be signed in to change notification settings - Fork 59
docs (modules/vnet): Fix variable description #236
Conversation
Changed `network_security_group_id` to `network_security_group`
Update variables.tf
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
@Lostmaniac9 - Thanks for opening this PR. Unfortunately we cannot merge it in this form, just two small steps to do before we can:
|
I am a bit confused with how to proceed with this. I have been trying to run pre-commit to update the README files but it keep failing when trying to validate terraform docs and tflint and gives an exit code of 127. Any reading I have done in the Contributing.md document hasn't been able to help me. I think I haven't installed tflint and terraform correctly but I'm not sure what I am missing. What's more is that it looks like above my comment several checks were run for my commit that all worked out so now I am wondering if anything is wrong at all. |
@Lostmaniac9 can you please paste the error you're getting here? |
@Lostmaniac9 not sure entirely. Perhaps try to install I will fix this for this PR |
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Co-authored-by: Migara Ekanayake <[email protected]>
Description
Changed id in Variables.tf from
network_security_group_id
tonetwork_security_group
Motivation and Context
#232
How Has This Been Tested?
I ran the pre-commit tests to what I understand to be the standards of the Contributing document.
Types of changes
Bug fix
Checklist
I am slightly unsure if I ran the pre-commit script correctly since I don't entirely understand what it does, but I believe it ran correctly and didn't have any significant issues to report.