This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
feat: GWLB integration #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbil
force-pushed
the
gwlb-support
branch
2 times, most recently
from
99f389b to
861f163
Compare
FoSix
reviewed
Feb 6, 2023
michalbil
force-pushed
the
gwlb-support
branch
from
861f163 to
7543028
Compare
michalbil
force-pushed
the
gwlb-support
branch
from
7543028 to
8cdcad1
Compare
michalbil
force-pushed
the
gwlb-support
branch
2 times, most recently
from
07b0db0 to
2d5c31c
Compare
FoSix
reviewed
Jul 3, 2023
…eating shared frontend
migara
approved these changes
Aug 2, 2023
FoSix
approved these changes
Aug 2, 2023
![prisma-cloud-devsecops[bot]](https://avatars.githubusercontent.com/in/135857?s=60&v=4){kind=small}
| @@ -64,6 +64,16 @@ resource "azurerm_virtual_machine" "this" { | |||
| version = var.custom_image_id == null ? var.img_version : null | |||
| } | |||
|
|
|||
| dynamic "plan" { | |||
There was a problem hiding this comment.
Azure instance does not authenticate using SSH keys
Resource: module.appvm.azurerm_virtual_machine.this | Policy ID: 806079733791502336_AZR_1680031706399 | Checkov ID: CKV_AZURE_1
Description
Refer the documentation for more details, https://docs.bridgecrew.io/docs/bc_azr_networking_1There was a problem hiding this comment.
@migara is there a way to skip some checks for this check? we do ignore them already in our checkov config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New module for GWLB deployment, support for service chaining in existing loadbalancer, new example with usage demonstration.
Motivation and Context
Resolves #218 .
How Has This Been Tested?
Apply, configure VM-series, verify traffic flow.
Types of changes
Checklist