This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
feat(module/appgw): add domain_name_label support for AppGW Public IP #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With domain_name_label, Azure will generate a fqdn for the Azure Application Gateway Public IP in <domain_name_label>.<region>.cloudapp.azure.com format.
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
pimielowski
suggested changes
Jan 12, 2023
There was a problem hiding this comment.
Like @sebastianczech said, you can get rid of the try() function.
migara
approved these changes
Jan 20, 2023
pimielowski
approved these changes
Feb 2, 2023
FoSix
reviewed
Feb 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With domain_name_label, Azure will generate a fqdn for the Azure Application Gateway Public IP in <domain_name_label>..cloudapp.azure.com format.
Motivation and Context
For testing it makes easy to get an fqdn that resolves to Application Gateway public IP.
How Has This Been Tested?
Tested on example code with the domain_name_label attribute and removing it.
Types of changes
Checklist