This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
feat(module/bootstrap)!: Enhanced user experience of the module usage #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migara
suggested changes
Jun 30, 2022
migara
changed the title
migara
changed the title
michalbil
reviewed
Jul 5, 2022
Co-authored-by: michalbil <[email protected]>
Co-authored-by: michalbil <[email protected]>
Co-authored-by: michalbil <[email protected]>
kbechler
approved these changes
Jul 7, 2022
Co-authored-by: Migara Ekanayake <[email protected]>
Co-authored-by: Migara Ekanayake <[email protected]>
michalbil
approved these changes
Jul 8, 2022
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on Terraform Registry and GitHub release
|
sebastianczech
pushed a commit
that referenced
this pull request
Oct 18, 2023
…#166) * refactor of the bootstrap module + example * adjust the existing module invocaton to reflect changes to variables * following sugestions from Migara * readme update * adjusting panorama example to fit changes made to bootstrap module * Update examples/bootstrap/README.md Co-authored-by: michalbil <[email protected]> * Update examples/transit_vnet_dedicated/main.tf Co-authored-by: michalbil <[email protected]> * Update examples/panorama/example.tfvars Co-authored-by: michalbil <[email protected]> * pr suggestions from @michalbil * adding validation for the storage_share_name variable * updates to readmes * Update examples/bootstrap/outputs.tf Co-authored-by: Migara Ekanayake <[email protected]> * Update examples/bootstrap/outputs.tf Co-authored-by: Migara Ekanayake <[email protected]> * adding back missing panorama name property * update readme * upgrading minimum version of terraform due to usage of alltrue function * update readme's Co-authored-by: michalbil <[email protected]> Co-authored-by: Migara Ekanayake <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor of the
bootstrapmodule that follows requirements found in real-life.Things worth mentioning are:
nullcauses a share to be recreated during each Terraform run. Defaults toCoolfor cost limitation (it is only used once, during bootstrap) but can be customised.The bootstrap example was also modified to show how the module can be used to create a single Storage Account with two File Shares for Transit VNET Ref Arch (based on real requirements).
Motivation and Context
existing_storage_accountwas duplicating the logicHow Has This Been Tested?
The
boostrapexample was used to test the module development. All examples using the module were run to verify backwards compatibility. If braking changes were found, examples were adjusted accordingly.Screenshots (if appropriate)
Types of changes
Checklist