fix(example): remove default value for olb_private_ip

Co-authored-by: Łukasz Pawlęga <[email protected]>
PaloAltoNetworks · Feb 8, 2022 · 5934988 · 5934988
1 parent 307ecd4
commit 5934988
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 4 deletions.
diff --git a/examples/transit_vnet_common/README.md b/examples/transit_vnet_common/README.md
@@ -57,7 +57,7 @@ $ terraform apply
 | <a name="input_location"></a> [location](#input\_location) | The Azure region to use. | `string` | `"East US 2"` | no |
 | <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | A prefix for all the names of the created Azure objects. It can end with a dash `-` character, if your naming convention prefers such separator. | `string` | `"pantf"` | no |
 | <a name="input_network_security_groups"></a> [network\_security\_groups](#input\_network\_security\_groups) | Definition of Network Security Groups to create. Refer to the `vnet` module documentation for more information. | `any` | n/a | yes |
-| <a name="input_olb_private_ip"></a> [olb\_private\_ip](#input\_olb\_private\_ip) | The private IP address to assign to the outbound load balancer. This IP **must** fall in the `private_subnet` network. | `string` | `"10.110.0.21"` | no |
+| <a name="input_olb_private_ip"></a> [olb\_private\_ip](#input\_olb\_private\_ip) | The private IP address to assign to the outbound load balancer. This IP **must** fall in the `private_subnet` network. | `string` | n/a | yes |
 | <a name="input_outbound_lb_name"></a> [outbound\_lb\_name](#input\_outbound\_lb\_name) | Name of the outbound load balancer. | `string` | `"lb_outbound"` | no |
 | <a name="input_password"></a> [password](#input\_password) | Initial administrative password to use for all systems. Set to null for an auto-generated password. | `string` | `null` | no |
 | <a name="input_resource_group_name"></a> [resource\_group\_name](#input\_resource\_group\_name) | Name of the Resource Group to create. If not provided, it will be auto-generated. | `string` | `""` | no |

diff --git a/examples/transit_vnet_common/example.tfvars b/examples/transit_vnet_common/example.tfvars
@@ -15,6 +15,8 @@ allow_inbound_mgmt_ips = [
   "10.255.0.0/24",   # Example Panorama access
 ]
 
+olb_private_ip = "10.110.0.21"
+
 route_tables = {
   private_route_table = {
     routes = {

diff --git a/examples/transit_vnet_common/variables.tf b/examples/transit_vnet_common/variables.tf
@@ -130,7 +130,6 @@ variable "vnet_tags" {
 
 variable "olb_private_ip" {
   description = "The private IP address to assign to the outbound load balancer. This IP **must** fall in the `private_subnet` network."
-  default     = "10.110.0.21"
   type        = string
 }
 

diff --git a/examples/transit_vnet_dedicated/README.md b/examples/transit_vnet_dedicated/README.md
@@ -62,7 +62,7 @@ terraform ouput -json password
 | <a name="input_location"></a> [location](#input\_location) | The Azure region to use. | `string` | `"East US 2"` | no |
 | <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | A prefix for all the names of the created Azure objects. It can end with a dash `-` character, if your naming convention prefers such separator. | `string` | `"pantf"` | no |
 | <a name="input_network_security_groups"></a> [network\_security\_groups](#input\_network\_security\_groups) | Map of Network Security Groups to create. Refer to the `vnet` module documentation for more information. | `any` | n/a | yes |
-| <a name="input_olb_private_ip"></a> [olb\_private\_ip](#input\_olb\_private\_ip) | The private IP address to assign to the outbound load balancer. This IP **must** fall in the `private_subnet` network. | `string` | `"10.110.0.21"` | no |
+| <a name="input_olb_private_ip"></a> [olb\_private\_ip](#input\_olb\_private\_ip) | The private IP address to assign to the outbound load balancer. This IP **must** fall in the `private_subnet` network. | `string` | n/a | yes |
 | <a name="input_outbound_files"></a> [outbound\_files](#input\_outbound\_files) | Map of all files to copy to `outbound_storage_share_name`. The keys are local paths, the values are remote paths. Always use slash `/` as directory separator (unix-like), not the backslash `\`. For example `{"dir/my.txt" = "config/init-cfg.txt"}` | `map(string)` | `{}` | no |
 | <a name="input_outbound_lb_name"></a> [outbound\_lb\_name](#input\_outbound\_lb\_name) | Name of the outbound load balancer. | `string` | `"lb_outbound"` | no |
 | <a name="input_outbound_storage_share_name"></a> [outbound\_storage\_share\_name](#input\_outbound\_storage\_share\_name) | Name of storage share to be created that holds `files` for bootstrapping outbound VM-Series. | `string` | n/a | yes |

diff --git a/examples/transit_vnet_dedicated/example.tfvars b/examples/transit_vnet_dedicated/example.tfvars
@@ -15,6 +15,8 @@ allow_inbound_mgmt_ips = [
   "10.255.0.0/24",   # Example Panorama access
 ]
 
+olb_private_ip = "10.110.0.21"
+
 route_tables = {
   private_route_table = {
     routes = {

diff --git a/examples/transit_vnet_dedicated/variables.tf b/examples/transit_vnet_dedicated/variables.tf
@@ -141,7 +141,6 @@ variable "vnet_tags" {
 
 variable "olb_private_ip" {
   description = "The private IP address to assign to the outbound load balancer. This IP **must** fall in the `private_subnet` network."
-  default     = "10.110.0.21"
   type        = string
 }