Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

test: Use terraform-modules-vmseries-tests-skeleton package #351

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Aug 1, 2023

Description

PR delivers changes after merging PR 2 with samples for Terratest test skeleton:

  • in all Go files in folders examples and tests import was changed in order to use test skeleton for Terratest - github.com/PaloAltoNetworks/terraform-aws-vmseries-modules/go/testskeleton was replaced by github.com/PaloAltoNetworks/terraform-modules-vmseries-tests-skeleton/pkg/testskeleton
  • Go files with folders from go/testskeleton and go/helpers were removed

Motivation and Context

Changes are part of second task from the list in comments for the issue 86.

How Has This Been Tested?

Code was tested by executing make test for examples and go test -v . in tests subfolders for modules.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech marked this pull request as ready for review August 1, 2023 07:12
@sebastianczech sebastianczech requested a review from a team as a code owner August 1, 2023 07:12
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

go.mod Outdated Show resolved Hide resolved
@sebastianczech sebastianczech merged commit b2ed774 into main Aug 3, 2023
@sebastianczech sebastianczech deleted the use-test-skeleton-pkg branch August 3, 2023 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants