Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat(module/vpc): Add support for managed prefix list for rules in security groups #325

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

sebastianczech
Copy link
Contributor

Description

PR adds support for managed prefix list for rules in security groups, so from now it's possible to define list of CIDR blocks or list of prefix list IDs for ingress and egress rules.

Motivation and Context

#321

How Has This Been Tested?

Code was tested by creating managed prefix list in the lab and deploying isolated_design example with rules in security group, for which managed prefix list was used, not CIDR block.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech marked this pull request as ready for review June 22, 2023 07:26
@sebastianczech sebastianczech requested a review from a team as a code owner June 22, 2023 07:26
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastianczech sebastianczech merged commit 1314c1f into main Jun 22, 2023
@sebastianczech sebastianczech deleted the 321-managed-prefix-list branch June 22, 2023 09:53
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.2 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants