This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
feat(example/centralized_design): New example for centralized design model #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to discussion with Migara, we need to merge both examples into 1 more centralized model |
sebastianczech
changed the title
sebastianczech
changed the title
4 tasks
pimielowski
approved these changes
May 29, 2023
| } | ||
|
|
||
| ### PANORAMA | ||
| variable "panorama" { |
There was a problem hiding this comment.
I will propose to change name of the variable to some clear information that is corresponding to panorama config.
There was a problem hiding this comment.
Thank you for valuable feedback. I change it into:
There was a problem hiding this comment.
I changed this to panorama_attachment
4 tasks
|
🎉 This PR is included in version 0.4.2 🎉 The release is available on Terraform Registry and GitHub release
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR delivers 1 example with TGW in centralised model for traffic inspection:
Motivation and Context
#147
How Has This Been Tested?
Example was tested by deploying it in AWS cloud and connecting to existing and configured Panorama
Types of changes
Checklist