Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat: Improvements needed for tests of modules and fix in panorama example #279

Merged
merged 1 commit into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/standalone_panorama/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module "panorama" {
create_public_ip = var.panorama_create_public_ip
ebs_volumes = var.panorama_ebs_volumes
name = var.panorama_deployment_name
ebs_kms_key_alias = try(data.aws_kms_alias.current_arn[0].arn, null)
ebs_kms_key_alias = try(data.aws_kms_alias.current_arn[0].target_key_arn, null)
panorama_version = var.panorama_version
ssh_key_name = var.panorama_ssh_key_name
subnet_id = module.security_subnet_sets["mgmt"].subnets[var.panorama_az].id
Expand Down
1 change: 1 addition & 0 deletions modules/alb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ No modules.
| [aws_s3_bucket.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
| [aws_s3_bucket_acl.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
| [aws_s3_bucket_policy.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_policy) | resource |
| [aws_security_group_rule.alb_att](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule) | resource |
| [aws_elb_service_account.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/elb_service_account) | data source |
| [aws_iam_policy_document.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
| [aws_s3_bucket.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/s3_bucket) | data source |
Expand Down
12 changes: 12 additions & 0 deletions modules/alb/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,18 @@ resource "aws_s3_bucket_policy" "this" {
}
# ######################## #

## Add communication to ALB with ephemeral port

resource "aws_security_group_rule" "alb_att" {

from_port = 0
protocol = "all"
source_security_group_id = var.security_groups[0]
security_group_id = var.security_groups[0]
to_port = 0
type = "ingress"
}

# ## Application Load Balancer ##
resource "aws_lb" "this" {
name = var.lb_name
Expand Down
14 changes: 11 additions & 3 deletions modules/vpc_route/outputs.tf
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
output "route_details" {
value = [for k, v in aws_route.this : {
cidr = v.destination_cidr_block
mpl = v.destination_prefix_list_id
rtb = v.route_table_id
cidr = v.destination_cidr_block
mpl = v.destination_prefix_list_id
rtb = v.route_table_id
next_hop_transit_gateway_id = try(v.transit_gateway_id, null)
next_hop_gateway_id = try(v.gateway_id, null)
next_hop_nat_gateway_id = try(v.nat_gateway_id, null)
next_hop_network_interface_id = try(v.network_interface_id, null)
next_hop_vpc_endpoint_id = try(v.vpc_endpoint_id, null)
next_hop_vpc_peering_connection_id = try(v.vpc_peering_connection_id, null)
next_hop_egress_only_gateway_id = try(v.egress_only_gateway_id, null)
next_hop_local_gateway_id = try(v.local_gateway_id, null)
}
]
}