Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add ALB test coverage and refactor skeleton #275

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Add ALB test coverage and refactor skeleton #275

merged 6 commits into from
Jan 17, 2023

Conversation

pimielowski
Copy link
Contributor

@pimielowski pimielowski commented Jan 17, 2023 •
edited
Loading

Description

Add ALB test coverage

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pimielowski pimielowski requested a review from a team as a code owner January 17, 2023 11:56
@sebastianczech
Copy link
Contributor

sebastianczech commented Jan 17, 2023 •
edited
Loading

I think that file scripts/install.sh should not be empty, because GitHub action is using it.

Moreover while working on next tests for transit_gateway_attachment, I think that I need generic check function with terraformOptions *terraform.Options so I will add another one in helper after merging code.

Thanks for refactoring tests/internal/testskeleton/testskeleton.go :)

@pimielowski
Copy link
Contributor Author

I think that file scripts/install.sh should not be empty, because GitHub action is using it.

It is not, there is a problem with my local branch, try to fix it..

sebastianczech
sebastianczech approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@pimielowski pimielowski merged commit c8f644f into test-skeleton-165 Jan 17, 2023
@pimielowski pimielowski deleted the alb_test_coverage branch January 17, 2023 12:49
@pimielowski pimielowski linked an issue Jan 17, 2023 that may be closed by this pull request
Terratest coverage for alb AWS module #274
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastianczech sebastianczech sebastianczech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terratest coverage for alb AWS module
2 participants
@pimielowski @sebastianczech