This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
feat: Improvements needed for tests of modules and fix in panorama example #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #257 with tests and improvements was too big, so in #257 only tests are being merged and in this PR improvements and fixes. PR delivers:
alb
(resourceaws_security_group_rule
added)vpc_route
(outputs from module extended)standalone_panorama
(way of retrieving KMS key ID is changed - from alias we need to pass target_key_arn, not ARN of the key alias. Problem was reported by @migara and observed during testing, in which after deployment we are checking if there is changes planned, when we runterraform plan
just after deployment)Motivation and Context
There was a question to deliver in #257 only changes for tests
How Has This Been Tested?
It was tested together with #257
Types of changes
Checklist