Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat: Improvements needed for tests of modules and fix in panorama example #279

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Jan 24, 2023

Description

PR #257 with tests and improvements was too big, so in #257 only tests are being merged and in this PR improvements and fixes. PR delivers:

  • improvements in modules:
    • alb (resource aws_security_group_rule added)
    • vpc_route (outputs from module extended)
  • fixes in examples:
    • standalone_panorama (way of retrieving KMS key ID is changed - from alias we need to pass target_key_arn, not ARN of the key alias. Problem was reported by @migara and observed during testing, in which after deployment we are checking if there is changes planned, when we run terraform plan just after deployment)

Motivation and Context

There was a question to deliver in #257 only changes for tests

How Has This Been Tested?

It was tested together with #257

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@sebastianczech sebastianczech marked this pull request as ready for review January 24, 2023 15:30
@sebastianczech sebastianczech requested a review from a team as a code owner January 24, 2023 15:30
@migara migara merged commit 8e861fc into main Jan 24, 2023
@migara migara deleted the improvements-required-for-tests branch January 24, 2023 15:31
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.2 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants