Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Dead links in Terraform Registry #152

Closed
michalbil opened this issue Dec 7, 2021 · 1 comment · Fixed by #153
Closed

Dead links in Terraform Registry #152

michalbil opened this issue Dec 7, 2021 · 1 comment · Fixed by #153
Assignees
Labels
aws bug Something isn't working documentation Improvements or additions to documentation released
Milestone

Comments

@michalbil
Copy link
Contributor

Describe the bug

In Terraform Registry all links that are not absolute are not pointing to a valid target. This is a Registry specific issue.

Expected behavior

Links point to valid pages.

Current behavior

404 Not Found is returned.

Possible solution

All links should be absolute - either point directly to github tools (open issue/releases), a commit-specific absolute URL or unlinked (if commit specific URL is not acceptable).

Steps to reproduce

Go to https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/aws/0.1.0 and follow any of Releases, Open an issue or contributing guide links (there are others).

Screenshots

image

@michalbil michalbil added bug Something isn't working documentation Improvements or additions to documentation aws labels Dec 7, 2021
@michalbil michalbil added this to the v0.2.0 milestone Dec 7, 2021
@michalbil michalbil self-assigned this Dec 7, 2021
michalbil added a commit that referenced this issue Dec 7, 2021
Non-absolute links are dead in Terraform Registry
Fixes #152
michalbil added a commit that referenced this issue Dec 8, 2021
* fix(docs): correct dead links in main README

Non-absolute links are dead in Terraform Registry
Fixes #152

* Add valid link for contributing guide

Add valid link to external contributing guide - https://github.com/PaloAltoNetworks/terraform-best-practices/blob/main/CONTRIBUTING.md
Split from #145

Co-authored-by: Michał Bilski <[email protected]>
Co-authored-by: Migara Ekanayake <[email protected]>
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws bug Something isn't working documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant