Fix for None datatype in _parse_job_results() #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
|
I had a similar issue. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-04-11) ### Features * **ApplicationFilter:** Add new_appid parameter ([#547](#547)) ([bc96108](bc96108)) * **Firewall:** New fields for show_system_resources ([#544](#544)) ([9e8cc2a](9e8cc2a)) * Handling Log Collector Group (LCG) pushes ([#493](#493)) ([7e87952](7e87952)) * **panos/network:** Advanced routing engine ([#539](#539)) ([173bb8a](173bb8a)) * Enhance updater logic ([#548](#548)) ([23ed1ad](23ed1ad)) * **network.BgpPolicyRule:** Add action_community_modifier param ([#535](#535)) ([58ce888](58ce888)), closes [#534](#534) * **PanDevice:** add `is_ready()` ([#532](#532)) ([a6b018e](a6b018e)) ### Bug Fixes * **_parse_job_results:** Catch None details in response ([#471](#471)) ([f01ae25](f01ae25)), closes [#470](#470)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-04-11) ### Features * **ApplicationFilter:** Add new_appid parameter ([#547](#547)) ([bc96108](bc96108)) * **Firewall:** New fields for show_system_resources ([#544](#544)) ([9e8cc2a](9e8cc2a)) * Handling Log Collector Group (LCG) pushes ([#493](#493)) ([7e87952](7e87952)) * **panos/network:** Advanced routing engine ([#539](#539)) ([173bb8a](173bb8a)) * Enhance updater logic ([#548](#548)) ([23ed1ad](23ed1ad)) * **network.BgpPolicyRule:** Add action_community_modifier param ([#535](#535)) ([58ce888](58ce888)), closes [#534](#534) * **PanDevice:** add `is_ready()` ([#532](#532)) ([a6b018e](a6b018e)) ### Bug Fixes * **_parse_job_results:** Catch None details in response ([#471](#471)) ([f01ae25](f01ae25)), closes [#470](#470)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-04-11) ### Features * **ApplicationFilter:** Add new_appid parameter ([#547](#547)) ([bc96108](bc96108)) * **Firewall:** New fields for show_system_resources ([#544](#544)) ([9e8cc2a](9e8cc2a)) * Handling Log Collector Group (LCG) pushes ([#493](#493)) ([7e87952](7e87952)) * **panos/network:** Advanced routing engine ([#539](#539)) ([173bb8a](173bb8a)) * Enhance updater logic ([#548](#548)) ([23ed1ad](23ed1ad)) * **network.BgpPolicyRule:** Add action_community_modifier param ([#535](#535)) ([58ce888](58ce888)), closes [#534](#534) * **PanDevice:** add `is_ready()` ([#532](#532)) ([a6b018e](a6b018e)) ### Bug Fixes * **_parse_job_results:** Catch None details in response ([#471](#471)) ([f01ae25](f01ae25)), closes [#470](#470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an exception handler to catch datatype errors with jobs where details is None.
Motivation and Context
Resolve bug described in #470
How Has This Been Tested?
The command that encountered the issue were rerun and the response was successful.
Successful download response
{ "success":true, "result":"OK", "jobid":"18", "user":"None", "warnings":"None", "starttime":"2022/07/26 08:58:18", "endtime":"08:58:19", "messages":[ ], "devices":{ }, "xml":"<Element""response"at 0x7f68569ca180> }Tested against panos 9.1 using the pan-os-python poetry venv.
This is very small and self contained change and won't affect other parts of the code base.
Screenshots (if appropriate)
Types of changes
Checklist
- [ ] I have updated the documentation accordingly.- [ ] I have added tests to cover my changes if appropriate.- [ ] All new and existing tests passed.