Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish porting functions to the new client #70

Open
Tracked by #66
migara opened this issue Apr 19, 2024 · 2 comments
Open
Tracked by #66

Finish porting functions to the new client #70

migara opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
component/gosdk enhancement New feature or request

Comments

@migara
Copy link
Member

migara commented Apr 19, 2024

No description provided.

@migara migara mentioned this issue Apr 19, 2024
21 tasks
@sebastianczech sebastianczech self-assigned this Apr 24, 2024
@shinmog
Copy link
Collaborator

shinmog commented Apr 25, 2024

This is specific to functions on the current structs:

  • pango.Client
  • pango.Firewall
  • pango.Panorama

Other functions in the namespaces are not included in this.

I don't believe that all the old functions belong hanging off of the new client struct, I just think that there should still be a way to invoke those functions in the new framework. For some functions, maybe they belong in specific namespaces. Or perhaps the functions could be added as a new namespace (for example, there are a few functions about config locks. Perhaps that should be in a namespace instead).

@sebastianczech
Copy link
Contributor

sebastianczech commented May 24, 2024

Work for that issue was started in #109 , but it's only the beginning:

  • pango.XmlApiClient was renamed to pango.Client (it replaces old pango.Client)
  • currently not used files were removed from util package

For new pango.Client still there are missed below functions:

  • func (c *Client) Commit() {}
  • func (c *Client) CommitLocks() {}
  • func (c *Client) ConfigLocks() {}
  • func (c *Client) ConfigTree() {}
  • func (c *Client) LockCommits() {}
  • func (c *Client) LockConfig() {}

While implementing all functions for new Client and while creating new package commit, there should be taken into account changes prepared by @pimielowski in below PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gosdk enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants