fix!: gathered_filter to process regex correctly #583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regex expressions in
gathered
stategathered_filter
required extra escape chars which wasn't a valid regex in deed.This PR allows to write valid regex expression in the
gathered_filter
, the previous syntax is not valid anymore hence this is introducing a breaking change.shlex.split()
was used to split logic expressions in thegathered_filter
, which also escaped(removed) backslash\
chars from the expression and led to a non-working regex. We have implemented our split method using shlex but removing backslash(\
) escape char from shlex instance to avoid escaping and properly processing regex expressions.Motivation and Context
Fixes #579
How Has This Been Tested?
Tested on vm firewalls with examples in the issue.
Types of changes
Checklist