Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panos_facts.py): Fixed virtual systems fact name #558

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

horiagunica
Copy link
Collaborator

@horiagunica horiagunica commented Mar 26, 2024

Description

This PR fixes #532 .

Motivation and Context

Wrong fact name.

How Has This Been Tested?

Local library and test file:

TASK [Print vsys facts] ****************************************************************************
ok: [panorama-mgmt-main] => {
    "vsys": {
        "ansible_facts": {
            "ansible_net_full_commit_required": false,
            "ansible_net_gather_subset": [
                "system",
                "vsys"
            ],
            "ansible_net_hostname": "vma-test",
            "ansible_net_model": "PA-VM",
            "ansible_net_multivsys": "off",
            "ansible_net_serial": "",
            "ansible_net_uncommitted_changes": false,
            "ansible_net_uptime": "0 days, 4:38:10",
            "ansible_net_version": "11.1.0",
            "ansible_net_virtual_systems": [
                {
                    "vsys_currentsessions": "3",
                    "vsys_description": null,
                    "vsys_id": "1",
                    "vsys_iflist": [
                        "ethernet1/1",
                        "ethernet1/2"
                    ],
                    "vsys_maxsessions": "0",
                    "vsys_name": "vsys1",
                    "vsys_vrlist": [],
                    "vsys_zonelist": [
                        "some-zone"
                    ]
                }
            ]
        },
        "changed": false,
        "failed": false
    }
}

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@horiagunica horiagunica changed the title Fixed virtual systems name fix(panos_facts.py): Fixed virtual systems fact name Mar 26, 2024
@horiagunica horiagunica merged commit 0d0fd6d into develop Mar 29, 2024
16 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-04-17)

### Features

* Add new option to panos_active_in_ha module ([#560](#560)) ([a2870f5](a2870f5))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([#552](#552)) ([73c28a8](73c28a8))
* **panos_facts.py:** Fixed virtual systems fact name ([#558](#558)) ([0d0fd6d](0d0fd6d))
Copy link

🎉 This PR is included in version 2.20.0 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

@alperenkose alperenkose deleted the fix-vsys-facts branch September 24, 2024 08:08
github-actions bot pushed a commit to alperenkose/pan-os-ansible that referenced this pull request Sep 24, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-09-24)

### Features

* Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79))
* Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8))
* new release for failed ci ([3872708](3872708))
* requirements.txt update python version and remove hashes ([905b1eb](905b1eb))
* **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d))
* **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
github-actions bot pushed a commit to alperenkose/pan-os-ansible that referenced this pull request Sep 25, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-09-25)

### Features

* Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79))
* Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5))
* ee ci for development ([97c31ba](97c31ba))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8))
* new release for failed ci ([3872708](3872708))
* requirements.txt update python version and remove hashes ([905b1eb](905b1eb))
* **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d))
* **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
github-actions bot pushed a commit to alperenkose/pan-os-ansible that referenced this pull request Sep 25, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-09-25)

### Features

* Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79))
* Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5))
* ee ci for development ([97c31ba](97c31ba))
* test ee ci for release ([a7605af](a7605af))

### Bug Fixes

* Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8))
* new release for failed ci ([3872708](3872708))
* requirements.txt update python version and remove hashes ([905b1eb](905b1eb))
* **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d))
* **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panos_facts has typo when returning gather_subset "vsys"
4 participants