Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
requirements.txt
in the root of the repo to include entries and hashes forcryptography
andpyopenssl
. These are dependencies ofpanos-upgrade-assurance
. Attempting to use the previous requirements file would fail as it would attempt to installcryptography
andpyopenssl
, and find no entry for these libraries or their hashes. In hash mode, pip is very clear that all installed packages must have hashes.The file
requirements.yml
was also added. This file documents any and all Ansible collections this collection depends on. Even mention of itself is important for using Dockerfile or ansible-builder to create stable execution spaces.Tested using a fresh install of Ubuntu 22.04 LTS,
ansible [core 2.16.1]
,python version = 3.10.12
, andjinja version = 3.0.3
. Was able to successfuly run thepanos_facts
module against panos_VM.Updated README.md to include instructions on how to use requirements.txt with pip.
Motivation and Context
Previously, attempting to use
requirements.txt
with pip would fail. For the purposes of a creating a stable Ansible environment for running playbooks, it is necessary to correctly documentrequirements.txt
so that it may be used in conjunctions with Dockerfile or ansible-builder to create a container space for execution purposes.The file
requirements.yml
was also added. This file documents any and all Ansible collections this collection depends on. Even mention ofpaloaltonetwork.panos
is important for using Dockerfile or ansible-builder to create stable execution spaces.Literature regarding proper documentation of dependencies in Ansible may be found at the following:
https://ansible.readthedocs.io/projects/builder/en/stable/collection_metadata/
How Has This Been Tested?
Tested using a fresh install of Ubuntu 22.04 LTS,
ansible [core 2.16.1]
,python version = 3.10.12
, andjinja version = 3.0.3
. Was able to successfully run thepanos_facts
module against panos_VM.The command
ansible-test sanity --local
is also still passing, however, no changes made by this commit would cause it to fail. This is mostly documentation and version control stability.Types of changes
Checklist