Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI & docs: Update CI and update examples for ansible-lint #503

Conversation

jamesholland-uk
Copy link
Member

@jamesholland-uk jamesholland-uk commented Oct 4, 2023

Description

  1. Updating per-module code examples to comply with new requirements of ansible-lint
  2. Updating CI to fix ansible-lint execution
    Note: Wouldn't normally put two changes in one PR, but both are required to pass ansible-lint due to changes listed below.

Motivation and Context

1.ansible-lint is now checking the examples code where it previously did not (ref), and ansible-lint is a requirement for certification.
2. ansible-lint had a breaking change within a minor release (ref) which required a CI change to fix on our side

How Has This Been Tested?

Tested locally with ansible-lint 6.20.4.dev4 and on a personal fork of this repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@jamesholland-uk jamesholland-uk changed the title docs: Update examples for ansible-lint CI & docs: Update CI and update examples for ansible-lint Oct 4, 2023
@jamesholland-uk jamesholland-uk mentioned this pull request Oct 4, 2023
4 tasks
@jamesholland-uk jamesholland-uk merged commit 9e9d934 into PaloAltoNetworks:develop Oct 5, 2023
8 checks passed
@jamesholland-uk jamesholland-uk deleted the update-examples-for-ansible-lint branch October 5, 2023 14:17
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

🎉 This PR is included in version 2.17.7 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant