Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt reconcile #76

Merged
merged 3 commits into from
Apr 13, 2019
Merged

Adapt reconcile #76

merged 3 commits into from
Apr 13, 2019

Conversation

dstiliadis
Copy link
Contributor

Changes the signature of the Reconcile method in order to allow reconciles to change the type of object provided in the interface.

@ghost
Copy link

ghost commented Apr 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "adapt-reconcile",
    "component": "manipulate",
    "pr-id": "76",
    "commit-sha": "f11f4575efe44965408e9c4ab3be55a9b7f5c4d5"
  },
  {
    "project": "adapt-reconcile",
    "component": "backend",
    "pr-id": "361",
    "commit-sha": "af8a55b8251589f9d2ecd3902aaedf455cc720da"
  }
]

@dstiliadis dstiliadis requested a review from primalmotion April 12, 2019 00:16
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #76 into master will increase coverage by 0.03%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   77.98%   78.01%   +0.03%     
==========================================
  Files          34       34              
  Lines        2852     2856       +4     
==========================================
+ Hits         2224     2228       +4     
  Misses        539      539              
  Partials       89       89
Impacted Files Coverage Δ
manipvortex/reconciler.go 100% <100%> (ø) ⬆️
manipvortex/manipulator.go 69.84% <72.72%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c7b06...e4c4b95. Read the comment docs.

@ghost
Copy link

ghost commented Apr 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "adapt-reconcile",
    "component": "manipulate",
    "pr-id": "76",
    "commit-sha": "f11f4575efe44965408e9c4ab3be55a9b7f5c4d5"
  },
  {
    "project": "adapt-reconcile",
    "component": "backend",
    "pr-id": "361",
    "commit-sha": "af8a55b8251589f9d2ecd3902aaedf455cc720da"
  },
  {
    "project": "adapt-reconcile",
    "component": "underwater",
    "pr-id": "51",
    "commit-sha": "947eea443e9ccb39101896747bdcd43fa647dd62"
  }
]

@ghost
Copy link

ghost commented Apr 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "adapt-reconcile",
    "component": "manipulate",
    "pr-id": "76",
    "commit-sha": "f11f4575efe44965408e9c4ab3be55a9b7f5c4d5"
  },
  {
    "project": "adapt-reconcile",
    "component": "backend",
    "pr-id": "361",
    "commit-sha": "af8a55b8251589f9d2ecd3902aaedf455cc720da"
  },
  {
    "project": "adapt-reconcile",
    "component": "enforcerd",
    "pr-id": "1114",
    "commit-sha": "9947d98f068a05f525984bed102c3f4b30d8f4ab"
  },
  {
    "project": "adapt-reconcile",
    "component": "underwater",
    "pr-id": "51",
    "commit-sha": "947eea443e9ccb39101896747bdcd43fa647dd62"
  }
]

@ghost
Copy link

ghost commented Apr 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "adapt-reconcile",
    "component": "underwater",
    "pr-id": "51",
    "commit-sha": "947eea443e9ccb39101896747bdcd43fa647dd62"
  },
  {
    "project": "adapt-reconcile",
    "component": "manipulate",
    "pr-id": "76",
    "commit-sha": "f11f4575efe44965408e9c4ab3be55a9b7f5c4d5"
  },
  {
    "project": "adapt-reconcile",
    "component": "backend",
    "pr-id": "361",
    "commit-sha": "af8a55b8251589f9d2ecd3902aaedf455cc720da"
  },
  {
    "project": "adapt-reconcile",
    "component": "enforcerd",
    "pr-id": "1114",
    "commit-sha": "9947d98f068a05f525984bed102c3f4b30d8f4ab"
  }
]

@ghost
Copy link

ghost commented Apr 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "adapt-reconcile",
    "component": "underwater",
    "pr-id": "51",
    "commit-sha": "3031973357a3b3f55d1a75398682607b9a04f6ab"
  },
  {
    "project": "adapt-reconcile",
    "component": "manipulate",
    "pr-id": "76",
    "commit-sha": "e4c4b95e300d6873d64badfbb386686cfe0b2586"
  },
  {
    "project": "adapt-reconcile",
    "component": "backend",
    "pr-id": "361",
    "commit-sha": "cd8fd2a5fe887044aa08eeb72d282922ca9f1908"
  },
  {
    "project": "adapt-reconcile",
    "component": "enforcerd",
    "pr-id": "1114",
    "commit-sha": "8a9a84481c4a00f6127d50162d67f7fe452ec81c"
  }
]

@ghost
Copy link

ghost commented Apr 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "adapt-reconcile",
    "component": "underwater",
    "pr-id": "51",
    "commit-sha": "3031973357a3b3f55d1a75398682607b9a04f6ab"
  },
  {
    "project": "adapt-reconcile",
    "component": "manipulate",
    "pr-id": "76",
    "commit-sha": "e4c4b95e300d6873d64badfbb386686cfe0b2586"
  },
  {
    "project": "adapt-reconcile",
    "component": "backend",
    "pr-id": "361",
    "commit-sha": "cd8fd2a5fe887044aa08eeb72d282922ca9f1908"
  },
  {
    "project": "adapt-reconcile",
    "component": "enforcerd",
    "pr-id": "1114",
    "commit-sha": "4ac0eaea6ca0e02339814c00cdd08a26399caf1b"
  }
]

@dstiliadis dstiliadis merged commit 63fafb4 into master Apr 13, 2019
@dstiliadis dstiliadis deleted the adapt-reconcile branch April 13, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant