Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enum descriptions in schema object #981

Merged

Conversation

tuanpt-0634
Copy link
Contributor

Description

#951 added support for x-enumDescriptions but it on get x-enumDescriptions on parameter with schema type array. This pull add support for other schema type.

Motivation and Context

Additional enhancement for #951

How Has This Been Tested?

Tested by adding a test schema demo/examples/tests/enumDescriptions.yaml

Screenshots (if appropriate)

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link

github-actions bot commented Oct 2, 2024

Visit the preview URL for this PR (updated for commit 3eed555):

https://docusaurus-openapi-36b86--pr981-yrnvvo1r.web.app

(expires Fri, 01 Nov 2024 13:39:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata
Copy link
Member

sserrata commented Oct 2, 2024

Thanks for the PR @tuanpt-0634! I also appreciate the test OpenAPI spec, makes things much clearer.

@sserrata sserrata merged commit 0063174 into PaloAltoNetworks:main Oct 2, 2024
13 checks passed
sserrata added a commit that referenced this pull request Oct 3, 2024
sserrata added a commit that referenced this pull request Oct 7, 2024
sserrata added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants