PlantUmlJob extension with system and allocation. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will not be needed until the Palladio-Addons-PlantUML supports ResourceEnvironments, which might still be far away. Better keep the code base clean until then.
FloBoJa
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
I removed the unused argument since that resource environment change might take a while still. We can add it back once we are there. I also made sure everything was formatted correctly.
The diagrams look awful right now (or do not work at all!), but that is something to take care of in Palladio-Addons-PlantUML, not in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.