fix: ensure secret configuration values are secret #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Jacobs <[email protected]>
10 tasks
t1agob
approved these changes
Mar 1, 2024
t1agob
added a commit
to PagerDuty/backstage-plugin
that referenced
this pull request
Mar 1, 2024
### Description Removes the `pagerDuty.apiToken` and `pagerDuty.oauth` configuration definitions from this repository as they should be treated as secret config and this frontend plugin does not need to know about them. See PagerDuty/backstage-plugin-backend#36 for a related PR to mark those configuration values as secret. ### Type of change - [ ] New feature (non-breaking change which adds functionality) - [x] Fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Checklist - [x] I have performed a self-review of this change - [x] Changes have been tested - [x] Changes are documented - [x] Changes generate *no new warnings* - [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) If this is a breaking change 👇 - [ ] I have documented the migration process - [ ] I have implemented necessary warnings (if it can live side by side) ## Acknowledgement By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Disclaimer:** We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
config.d.tsvalues to markpagerDuty.apiTokenandpagerDuty.oauthas secret values.These are only used by the backend currently and should not be made visible to the frontend.
See https://backstage.io/docs/conf/defining/#visibility for more details
See related PagerDuty/backstage-plugin#78 to remove configuration from the frontend plugin.
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.