Merge pull request #77 from PagerDuty/chore/remove-json-parse-on-pote…

…ntial-undefined-bits chore: refactor JSON.parse usage on unsafe code
PagerDuty · Jul 23, 2024 · 0e93601 · 0e93601
2 parents 49adf3b + d6b4fdf
commit 0e93601
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/service/router.ts b/src/service/router.ts
@@ -28,10 +28,9 @@ export async function createComponentEntitiesReferenceDict({ items: componentEnt
     const componentEntitiesDict: Record<string, { ref: string, name: string }> = {};
 
     await Promise.all(componentEntities.map(async (entity) => {
-        const annotations: Annotations = JSON.parse(JSON.stringify(entity.metadata.annotations));
-        const serviceId = annotations['pagerduty.com/service-id'];
-        const integrationKey = annotations['pagerduty.com/integration-key'];
-        const account = annotations['pagerduty.com/account'] ?? "";
+        const serviceId = entity.metadata.annotations?.['pagerduty.com/service-id'];
+        const integrationKey = entity.metadata.annotations?.['pagerduty.com/integration-key'];
+        const account = entity.metadata.annotations?.['pagerduty.com/account'];
 
         if (serviceId !== undefined && serviceId !== "") {
             componentEntitiesDict[serviceId] = {