-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support padding removing. #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
deep_speech_2/data_utils/data.py
Outdated
|
||
padded_instance = [padded_audio, text] | ||
padded_conv0_h = (padded_audio.shape[0] - 1) // 2 + 1 | ||
padded_conv0_w = (padded_audio.shape[1] - 1) // 3 + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments for the hard-coded parameters here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
deep_speech_2/model_utils/network.py
Outdated
@@ -248,9 +269,16 @@ def deep_speech_v2_network(audio_data, | |||
stride_y=1, | |||
block_x=1, | |||
block_y=conv_group_height) | |||
# remove padding part | |||
remove_padding = paddle.layer.sub_seq( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better name would be like padding_removed_data
or something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adapt tuning script to padding removing #444
Resolves #442