-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci #106
Fix ci #106
Conversation
1. Unify the dependency installation process in setup.sh. 2. Change the version of package scipy from 0.13.0b1 to 0.13.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM.
Please also modify README.md accordingly.
deep_speech_2/setup.sh
Outdated
if [ -f 'requirements.txt' ]; then | ||
pip install -r requirements.txt | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
deep_speech_2/setup.sh
Outdated
rm libsamplerate-0.1.9.tar.gz | ||
pip install scikits.samplerate==0.3.3 | ||
if [ $? != 0 ]; then | ||
echo "Install sckikits.samplerate failed !!!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sckikits --> scikits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
deep_speech_2/setup.sh
Outdated
if [ $? != 0 ]; then | ||
echo "Install sckikits.samplerate failed !!!" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all successful, print something like "All done."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow comments.
deep_speech_2/setup.sh
Outdated
if [ -f 'requirements.txt' ]; then | ||
pip install -r requirements.txt | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
deep_speech_2/setup.sh
Outdated
rm libsamplerate-0.1.9.tar.gz | ||
pip install scikits.samplerate==0.3.3 | ||
if [ $? != 0 ]; then | ||
echo "Install sckikits.samplerate failed !!!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
deep_speech_2/setup.sh
Outdated
if [ $? != 0 ]; then | ||
echo "Install sckikits.samplerate failed !!!" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
resolves #105
Fix ci following:
1. Unify the dependency installation process in setup.sh.
2. Change the version of package scipy from 0.13.0b1 to 0.13.1