Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #106

Merged
merged 2 commits into from
Jun 20, 2017
Merged

Fix ci #106

merged 2 commits into from
Jun 20, 2017

Conversation

pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Jun 19, 2017

resolves #105
Fix ci following:
1. Unify the dependency installation process in setup.sh.
2. Change the version of package scipy from 0.13.0b1 to 0.13.1

    1. Unify the dependency installation process in setup.sh.
    2. Change the version of package scipy from 0.13.0b1 to 0.13.1
@pkuyym pkuyym changed the title Fix ci following: Fix ci Jun 19, 2017
Copy link
Contributor

@xinghai-sun xinghai-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM.
Please also modify README.md accordingly.

if [ -f 'requirements.txt' ]; then
pip install -r requirements.txt
fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the blank line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

rm libsamplerate-0.1.9.tar.gz
pip install scikits.samplerate==0.3.3
if [ $? != 0 ]; then
echo "Install sckikits.samplerate failed !!!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sckikits --> scikits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

if [ $? != 0 ]; then
echo "Install sckikits.samplerate failed !!!"
exit 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all successful, print something like "All done."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow comments.

if [ -f 'requirements.txt' ]; then
pip install -r requirements.txt
fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

rm libsamplerate-0.1.9.tar.gz
pip install scikits.samplerate==0.3.3
if [ $? != 0 ]; then
echo "Install sckikits.samplerate failed !!!"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

if [ $? != 0 ]; then
echo "Install sckikits.samplerate failed !!!"
exit 1
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pkuyym pkuyym merged commit 6a697c2 into PaddlePaddle:develop Jun 20, 2017
@pkuyym pkuyym deleted the fix_ci branch June 20, 2017 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ci
2 participants