Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][BUPT][Add API Legend No.24]为slice_scatter添加图例 #6974

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ZHOU05030
Copy link

为slice_scatter添加图例
@zacary(孙钟恺)
@zoooo0820

Copy link

paddle-bot bot commented Nov 15, 2024

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6974.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 18, 2024
@ZHOU05030 ZHOU05030 changed the title [Docathon][Add API Legend No.24]为slice_scatter添加图例 [Docathon][BUPT][Add API Legend No.24]为slice_scatter添加图例 Nov 18, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参照示例 PR 做图例吧,这样有点太难理解了

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 图中大小写保持统一,比如 Axis=0 和 axis=1 一个大写一个小写, Strides 和 starts 都是参数,为什么也是一个大写一个小写
  • 像参数 starts,ends,strides 数据类型是 list|tuple,图中用 int 不太准确,可以写成 starts: [2] ...(参数数据类型看文档的参数部分)
  • 图中少了重要参数 axes
  • 方向键下的 broadcast 可能会带来误解,不知道 valuex 两个 tensor 放在两行,然后 value 单独展示 broadcast 的过程,最后方向键合并到结果
  • 张量名能否加粗,如 Tensor: x .. 中的 x 加粗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants