Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 3 No.20】为 Paddle 新增 vsplit API #5213

Merged
merged 5 commits into from
Sep 9, 2022
Merged

【PaddlePaddle Hackathon 3 No.20】为 Paddle 新增 vsplit API #5213

merged 5 commits into from
Sep 9, 2022

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Aug 27, 2022 •
edited by SigureMo
Loading

增加 paddle.vsplit 的中文文档

PADDLEPADDLE_PR=44853

@paddle-bot
Copy link

paddle-bot bot commented Aug 27, 2022

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-5213.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：[Beta]飞桨文档预览工具

@Asthestarsfalll Asthestarsfalll mentioned this pull request Aug 27, 2022
Merged
SigureMo
SigureMo requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 API 可以通过 paddle.vsplit 访问到吧，那需要在 docs/api/paddle/Overview_cn.rst 添加相关内容

另外最好也在 docs/api/api_label 添加一下英文文档 label

以及需要安装 pre-commit 解决下代码风格问题（docs repo 下也需要 pre-commit install 一下以注册 hooks）

image

docs/api/paddle/vsplit_cn.rst Outdated Show resolved Hide resolved
docs/api/paddle/vsplit_cn.rst Outdated Show resolved Hide resolved
docs/api/paddle/vsplit_cn.rst Show resolved Hide resolved
SigureMo
SigureMo requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其余应该没什么问题了

docs/api/paddle/vsplit_cn.rst Outdated Show resolved Hide resolved
docs/api/paddle/vsplit_cn.rst Outdated Show resolved Hide resolved
@Ligoml
Copy link
Collaborator

Ligoml commented Sep 2, 2022

@Asthestarsfalll 请尽快处理一下文档的意见哈

@Asthestarsfalll
Copy link
Contributor Author

@Asthestarsfalll 请尽快处理一下文档的意见哈

已处理

SigureMo
SigureMo approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~

Ligoml
Ligoml approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ligoml Ligoml merged commit 325496d into PaddlePaddle:develop Sep 9, 2022
@SigureMo SigureMo mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor status: proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asthestarsfalll @Ligoml @SigureMo