Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cn docs for all_gather_object, modified docs for all_gather, split #5087

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Jul 26, 2022

增加paddle.distributed.all_gather_object的中文文档。
修改paddle.distributed.all_gather和paddle.split的中文文档。

该算子的实现PR为PaddlePaddle/Paddle#44417
PADDLEPADDLE_PR=44417

@LiYuRio LiYuRio changed the title add cn docs for all_gather_object, modified docs for all_gather and s… add cn docs for all_gather_object, modified docs for all_gather, split Jul 26, 2022
@LiYuRio LiYuRio force-pushed the dev_add_dtype branch 2 times, most recently from 89ac8e9 to 7a81eab Compare July 26, 2022 10:59
@Ligoml
Copy link
Collaborator

Ligoml commented Jul 26, 2022

返回
:::::::::

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么英文里有个warning,中文没有呀?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已添加

@@ -11,7 +11,7 @@ split

参数
:::::::::
- **x** (Tensor) - 输入变量,数据类型为bool、float16、float32、float64、int32、int64的多维Tensor。
- **x** (Tensor) - 输入变量,数据类型为bool、float16、float32、float64、uint8、int8、int32、int64的多维Tensor。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

中英文数据类型不一致?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是英文注释写错了,已在代码里修改

- tensor_list (list) - 操作的输出Tensor列表。列表中的每个元素均为Tensor,每个Tensor的数据类型为:float16、float32、float64、int32、int64。
- tensor (Tensor) - 操作的输入Tensor。Tensor的数据类型为:float16、float32、float64、int32、int64。
- tensor_list (list) - 操作的输出Tensor列表。列表中的每个元素均为Tensor,每个Tensor的数据类型为:float16、float32、float64、int32、int64、uint8、bool、int8、complex64、complex128
- tensor (Tensor) - 操作的输入Tensor。Tensor的数据类型为:float16、float32、float64、int32、int64、uint8,bool、int8、complex64、complex128
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文API文档的数据类型顺序统一一下吧,这个没啥不统一的理由

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已统一

@Ligoml Ligoml merged commit c37683a into PaddlePaddle:develop Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants