【Hackathon 5 No.16】为 Paddle 新增 EmbeddingBag API #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luotao1 @Charles-hit 麻烦review下，谢谢。 |
Charles-hit
reviewed
Oct 12, 2023
|
|
||
| # 四、对比分析 | ||
|
|
||
| 可以直接参考的实现是pytorch，涉及到的API在Paddle中均有实现，可以想到用Paddle API组合实现相同的逻辑 |
There was a problem hiding this comment.
这个任务需要在之前未开发完的PR上接着进行开发，需要手写embeddingbag算子。
There was a problem hiding this comment.
汗。可以在之前开发者https://github.com/PaddlePaddle/Paddle/pull/49000基础上进行开发。 这里写的是可以呀！
麻烦确认下是否能组和实现。
There was a problem hiding this comment.
出于性能的考量，这个算子要求写kernel的哈，因为之前已经开发过一版了，需要在那个pr基础上完成后续工作的开发。
|
|
||
| ## 命名与参数设计 | ||
|
|
||
| API设计为`paddle.nn.functional.embedding_bag(num_embeddings, embedding_dim, padding_idx=None, sparse=False, weight_attr=None, name=None, mode='mean')`和`paddle.nn.EmbeddingBag(num_embeddings, embedding_dim, padding_idx=None, sparse=False, weight_attr=None, name=None, mode='mean')` |
| elif self._mode == "mean": | ||
| return paddle.mean(out, axis=1) | ||
| elif self._mode == "max": | ||
| return paddle.max(out, axis=-1) |
|
|
||
| # 六、测试和验收的考量 | ||
|
|
||
| 测试考虑的case如下： |
There was a problem hiding this comment.
测试需要对sparse也进行测试，可以写一下完成的测试方案，比如考虑哪些边界条件。
|
@luotao1 @Charles-hit 麻烦确认下是否能组和实现？ |
|
@lisamhy 如 #687 (comment) 所说，不能组合实现，需要新增 Kernel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaddlePaddle/Paddle#57262