[CodeStyle] add introducing isort
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Nov 14, 2022
luotao1
reviewed
Nov 17, 2022
|
|
||
| ### 推进方式 | ||
|
|
||
| 第一个 PR（即 [PaddlePaddle/Paddle#46475](https://github.com/PaddlePaddle/Paddle/pull/46475)）添加配置并修复部分文件，之后每个 PR 修复一部分文件（尽可能保持在 1000 左右，以避免 PR-CI-Coverage 流水线崩溃在参数传递处），利用大概 5 个以内 PR 修复绝大多数文件格式，之后利用一些 PR 专注于解决需要手动解决的问题。 |
There was a problem hiding this comment.
利用大概 5 个以内 PR 修复绝大多数文件格式
来自 @jeff41404 的建议，具体实施时建议找个不太冲突的时间集中改
There was a problem hiding this comment.
目前 PaddlePaddle/Paddle#46475 过去四天了，只有三个冲突，其实一般情况下不专门找时间应该也能合入（任意晚上提 PR，第二天白天 merge），集中找时间改还需要保证各个 PR 之间互不干涉，感觉有点麻烦
前两个 PR 主要修改单测应该冲突概率都不高，第三个及之后 PR 可能主要是其他部分，这部分可能冲突概率高一些，如果确实冲突概率高的话，可以考虑那部分再找时间来改
|
@SigureMo 本次评审不再单独增设会议，采用邮件（已发）+ 讨论的方式进行评审
|
XiaoguangHu01
approved these changes
Nov 21, 2022
|
@SigureMo 和 @XiaoguangHu01 @raindrops2sea 讨论，评审没有问题，可以现在就启动代码合入了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
引入 isort RFC
preview: https://github.com/cattidea/community/blob/rfc/isort/rfcs/CodeStyle/20221111_introducing_isort.md