【Hackathon No.26】 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 格式检查通过，你的PR 将接受Paddle 专家以及开源社区的review，请及时关注PR 动态 |
|
reviewing |
shiyutang
requested changes
Mar 15, 2022
| paddle.nn.TripletMarginLoss 是三元损失函数，其针对 anchor 和正负对计算 P 范数距离下的三元损失，从而获得损失值。 | ||
|
|
||
| ## 3、意义 | ||
| 使paddle支持更多的损失函数 |
There was a problem hiding this comment.
意义可以进一步具体化，比如增加APIxx，实现xx的功能。
| 无此功能，但可以在python层通过调用基础api的形式实现。 | ||
|
|
||
| # 三、业内方案调研 | ||
| torch有此api，是在c++层实现的，不过调用的基础op飞桨均有实现 |
There was a problem hiding this comment.
可以补充完整 torch api 的实现方式，包含关键代码和核心逻辑，从而明确实现原理
| 使paddle支持更多的损失函数 | ||
|
|
||
| # 二、飞桨现状 | ||
| 无此功能，但可以在python层通过调用基础api的形式实现。 |
There was a problem hiding this comment.
可以进一步参考 paddle 其他损失函数 API 实现方式，并对关键逻辑、是否可以复用进行描述
Comment on lines
+27
to
+28
| 本方案计划在python层开发，不涉及底层c++，故减轻了日后的编译开销，计算全部在c++层，不会损失性能。 | ||
| 且与torch的api一致，方便用户无缝迁移到paddle。 |
There was a problem hiding this comment.
对比分析部分可以阐述不同方案（torch，paddle，numpy，tensorflow等）对于参数设计差异，对参数维度支持差异，特殊场景支持差异等。
Comment on lines
+42
to
+43
| 核心功能放在functional中，在nn中暴露出来，方便用户调用，与其它api一致 | ||
|
|
Comment on lines
+45
to
+47
| - 数值正确性及稳定性 | ||
| - 支持的数据类型 | ||
| - 异常检测 |
|
你的PR有最新反馈，请及时修改。 |
|
#31 merged, this PR is closed, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 Paddle 新增 TripletMarginLoss 损失函数API rfc