Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.10】为 Paddle 新增 LogNormal API #248

Merged
merged 13 commits into from
Sep 8, 2022
Merged

【Hackathon No.10】为 Paddle 新增 LogNormal API #248

merged 13 commits into from
Sep 8, 2022

Conversation

MayYouBeProsperous
Copy link
Contributor

请老师指导。

@paddle-bot
Copy link

paddle-bot bot commented Sep 6, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@cxxly
Copy link

cxxly commented Sep 8, 2022

RFC写的相当不错。

1)文档中体现了实现LogNormal要解决重点问题,如对Normal TransformedDistribution修改,测试用例以Numpy为基准,实现同样的概率分布类进行对比
2)排期规划、影响面、名词解释、参考文档 等细节部分能体现认真在写RFC文档

能看出来,你确实是看懂了 PyTorch、Tensorflow probability、Paddle 概率分布整体设计思路。按照自己思路在进行设计,赞。

Copy link

@cxxly cxxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants