Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.22】为 Paddle 新增 paddle.incubate.sparse.reshape 稀疏 API #246

Merged
merged 3 commits into from
Sep 13, 2022
Merged

【Hackathon No.22】为 Paddle 新增 paddle.incubate.sparse.reshape 稀疏 API #246

merged 3 commits into from
Sep 13, 2022

Conversation

gsq7474741
Copy link
Contributor

为 Paddle 新增 paddle.incubate.sparse.reshape 稀疏 API

@paddle-bot
Copy link

paddle-bot bot commented Sep 5, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@gsq7474741 gsq7474741 mentioned this pull request Sep 5, 2022
Closed
@gsq7474741
Copy link
Contributor Author

已更新 @zhouwei25

zhwesky2010
zhwesky2010 reviewed Sep 9, 2022
View reviewed changes
rfcs/APIs/20220905_api_design_for_sparse_reshape.md Outdated Show resolved Hide resolved
rfcs/APIs/20220905_api_design_for_sparse_reshape.md Outdated Show resolved Hide resolved
rfcs/APIs/20220905_api_design_for_sparse_reshape.md Outdated Show resolved Hide resolved
rfcs/APIs/20220905_api_design_for_sparse_reshape.md Outdated

# 七、可行性分析及规划排期

方案主要自行实现核心算法，并使用paddle现有func
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写一下复用的两个func名

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦review下 谢谢 @zhouwei25

zhwesky2010
zhwesky2010 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，后面实现的时候再看看有没其他问题

@zhwesky2010 zhwesky2010 merged commit bbf96b6 into PaddlePaddle:master Sep 13, 2022
@Ligoml Ligoml mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

@Ligoml Ligoml

@zhwesky2010 zhwesky2010

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsq7474741 @zhwesky2010 @luotao1 @Ligoml