【Hackathon No.5】为 Paddle 新增 bucketize #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
PommesPeter
changed the title
jeff41404
reviewed
Jul 11, 2022
|
|
||
| 在实现方法上，PyTorch 是通过 C++ API 组合实现的，[代码位置](https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/Bucketization.cpp) | ||
|
|
||
| 实现代码： |
There was a problem hiding this comment.
only show the code of key logic to avoid taking up too much space.
jeff41404
reviewed
Jul 11, 2022
| - 参数 `right` 为 True 和 False 时输出的正确性 | ||
| - 参数 `out_int32` 为 True 和 False 时 dtype 输出的正确性； | ||
| - 未输入 `right` 时的输出正确性； | ||
| - 未输入 `out_int32` 时的输出正确性； |
There was a problem hiding this comment.
we should consider more testing case, eg, some error case... refer to unit test specification
jeff41404
reviewed
Jul 14, 2022
|
|
||
| # 八、影响面 | ||
|
|
||
| 新增 API，对其他模块是否有影响 |
There was a problem hiding this comment.
the impact needs to be explained, even no impact
|
lfy成为这个任务的leader，请参照 #176 设计方案进行开发 |
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨社区贡献指南，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.