-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon No.11】为 Paddle 新增 multi_margin_loss API #171
Conversation
你好,请先完成黑客松第二期的任务再参与第三期哦~ PaddlePaddle/Paddle#42364 |
name:str=None, | ||
) -> Tensor:` | ||
- input:Tensor, 维度为[batchsize,num_classes] | ||
- label:Tensor, 维度为[batchsize,1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议有这种形状要求。既然知道第二个维度 size 一定是 1, 那就直接不要这个维度,直接 (batch_size,) 即可。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
) -> Tensor:` | ||
- input:Tensor, 维度为[batchsize,num_classes] | ||
- label:Tensor, 维度为[batchsize,1] | ||
- weight: Optional[Tensor],维度为[num_classes,1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
- input:Tensor, 维度为[batchsize,num_classes] | ||
- label:Tensor, 维度为[batchsize,1] | ||
- weight: Optional[Tensor],维度为[num_classes,1] | ||
- reduction:str,'None','mean','sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议统一,都用小写字符串。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
关于输入的形状和参数,请作为参考。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add rfc of MultiMarginLoss