Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.11】add RFC for index_fill #122

Merged
merged 6 commits into from
Oct 21, 2022
Merged

【Hackathon No.11】add RFC for index_fill #122

merged 6 commits into from
Oct 21, 2022

Conversation

thunder95
Copy link
Contributor

新增api index_fill设计文档

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@thunder95 thunder95 mentioned this pull request Apr 30, 2022
Closed
This was referenced May 3, 2022
Closed
Closed
@thunder95
Copy link
Contributor Author

PR暂先提交: PaddlePaddle/Paddle#42454

iclementine
iclementine reviewed May 6, 2022
View reviewed changes
rfcs/APIs/20220429_api_design_for_index_fill.md Outdated

axis是index索引选择的轴, 只支持int参数类型。

index在指定轴上含索引下标的1-D Tensor。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议同时支持 python 的 list of int. 支持以 Tensor 或者非 Tensor 的方式传入此参数，这样使用更加灵活。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完成

iclementine
iclementine reviewed May 6, 2022
View reviewed changes
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提了若干设计细节的问题

@iclementine iclementine closed this May 6, 2022
@paddle-bot-old
Copy link

paddle-bot-old bot commented May 6, 2022

PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。
The format inspection passed. Your PR will be reviewed by experts of Paddle and developers from the open-source community. Stay tuned.

@iclementine iclementine reopened this May 6, 2022
@paddle-bot-old
Copy link

你的PR有最新反馈，请及时修改。
There’s the latest feedback about your PR. Please check.

@luotao1 luotao1 self-assigned this Aug 10, 2022
iclementine
iclementine approved these changes Oct 17, 2022
View reviewed changes
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实只需要写 value 是 tensor 的版本就可以了。value 是非 tensor 的版本可以不要。因为可以通过 to_tensor 把它先转为 tensor

@Ligoml Ligoml merged commit d3984cf into PaddlePaddle:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclementine iclementine iclementine approved these changes

Assignees

@luotao1 luotao1

@iclementine iclementine

@Ligoml Ligoml

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thunder95 @iclementine @luotao1 @dingjiaweiww @Ligoml