fix scalar random samplng #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Superjomn
commented
Jan 4, 2018
Superjomn
commented
- changing form random sample to equidistant sampling
daming-lu
reviewed
Jan 4, 2018
| end_idx = len(data) - 1 | ||
| res = [] | ||
| for i in xrange(num_records): | ||
| id = int(end_idx - i * span) |
| span = float(len(data) / num_records) | ||
| end_idx = len(data) - 1 | ||
| res = [] | ||
| for i in xrange(num_records): |
There was a problem hiding this comment.
这里逻辑有点问题。取 n 个点的话， 应该除以 （n-1)，比如 10个点取三个，应该是 10/2 = 5, 取 0， 5 ， 9
span = float(len(data)) / (num_records-1)
span_multiply = 0
data_idx = int(span_multiply * span)
sampled_data = []
while data_idx < len(data):
sampled_data.append(data[data_idx])
span_multiply += 1
data_idx = int(span_multiply * span)
sampled_data.append(data[-1])
return sampled_data
There was a problem hiding this comment.
现在是 10个点取3个的话：
9, 5, 0
reverse-> 0, 5, 9
这个应该没有问题 @daming-lu
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 12, 2018
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.