Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c++ brpc client #1370

Merged
merged 13 commits into from
Sep 1, 2021
Merged

Add c++ brpc client #1370

merged 13 commits into from
Sep 1, 2021

Conversation

ShiningZhang
Copy link
Collaborator

@ShiningZhang ShiningZhang commented Aug 30, 2021

  1. 添加c++ brpc client。添加了general-client/client以及brpc_client。
  2. 添加了使用示例general-client/example/simple_client,其中附带fit_a_line及bert的请求范例,并添加对应编译产出general-client/simple_client
  3. 添加general-client/README_CN.md,简要介绍simple_client参数配置。

相比较使用client.py的brpc请求方式,性能有一定程度提升。

@paddle-bot-old
Copy link

Thanks for your contribution!

@ShiningZhang ShiningZhang changed the title Add c++ brpc client example Add c++ brpc client Aug 30, 2021
@HexToString
Copy link
Collaborator

代码中适当加一些注释吧。
比如你的模板类中的T1、T2一般是什么

@bjjwwang
Copy link
Collaborator

如果能再统一pybind和C++代码维护一份就更好了,如果有公用的部分

@ShiningZhang
Copy link
Collaborator Author

代码中适当加一些注释吧。
比如你的模板类中的T1、T2一般是什么

已在代码中添加一些参数说明注释

@ShiningZhang
Copy link
Collaborator Author

如果能再统一pybind和C++代码维护一份就更好了,如果有公用的部分

开发时考虑到后续的grpc及http,所以使用client作为基类统一接口。同时为了不影响原本pybind接口故未对pybind部分作修改。后续可以梳理一下逻辑,看能否抽出一些公共代码作为函数共用。

Copy link
Collaborator

@TeslaZhao TeslaZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TeslaZhao TeslaZhao merged commit 5073046 into PaddlePaddle:develop Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants