-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c++ brpc client #1370
Add c++ brpc client #1370
Conversation
Thanks for your contribution! |
代码中适当加一些注释吧。 |
如果能再统一pybind和C++代码维护一份就更好了,如果有公用的部分 |
已在代码中添加一些参数说明注释 |
开发时考虑到后续的grpc及http,所以使用client作为基类统一接口。同时为了不影响原本pybind接口故未对pybind部分作修改。后续可以梳理一下逻辑,看能否抽出一些公共代码作为函数共用。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
相比较使用client.py的brpc请求方式,性能有一定程度提升。