Split byref op #9956
Merged
Split byref op #9956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
force-pushed
the
split_byref_op
branch
from
07de995
to
93b3c25
Compare
typhoonzero
force-pushed
the
split_byref_op
branch
from
93b3c25
to
c6d7c2b
Compare
Yancey1989
reviewed
Apr 18, 2018
paddle/fluid/framework/tensor_impl.h
Outdated
| @@ -162,6 +162,37 @@ inline Tensor& Tensor::ShareDataWith(const Tensor& src) { | |||
| return *this; | |||
| } | |||
|
|
|||
| inline Tensor& Tensor::ShareDataWith(const Tensor* src, size_t offset) { | |||
There was a problem hiding this comment.
Can we use Tensor::Slice instead of this new function?
Yancey1989
reviewed
Apr 18, 2018
paddle/fluid/framework/tensor.h
Outdated
| @@ -176,6 +176,34 @@ class Tensor { | |||
| std::type_index type_; | |||
| }; | |||
|
|
|||
| template <typename Place> | |||
| struct SharedPlaceholderImpl : public Placeholder { | |||
There was a problem hiding this comment.
Please delete the unused function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9675
Split tensors using shared data to reduce copying when doing distributed training. Currently split by axis0 is supported only.