Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/metrics #9791

Merged
merged 11 commits into from
Apr 11, 2018
Merged

Feature/metrics #9791

merged 11 commits into from
Apr 11, 2018

Conversation

dzhwinter
Copy link
Contributor

refactoring the evaluators. make it more user-friendly.

JiayiFeng
JiayiFeng reviewed Apr 10, 2018
View reviewed changes
python/paddle/fluid/metrics.py Outdated
self.num_correct_chunks = 0

def update(self, precision, recall, f1_score, num_infer_chunks,
num_label_chunks, num_correct_chunks):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check 'is_numpy' here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

JiayiFeng
JiayiFeng approved these changes Apr 11, 2018
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@dzhwinter dzhwinter merged commit d52fa26 into PaddlePaddle:develop Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzhwinter @JiayiFeng