Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite memroy/detail #9719

Merged
merged 17 commits into from
Apr 8, 2018
Merged

Rewrite memroy/detail #9719

merged 17 commits into from
Apr 8, 2018

Conversation

wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Apr 8, 2018 •
edited
Loading

Fixes #9700
Fixes #9720

@wangkuiyi wangkuiyi mentioned this pull request Apr 8, 2018
Closed
@wangkuiyi wangkuiyi changed the title Rewrite the interface of memroy/detail Rewrite memroy/detail Apr 8, 2018
@wangkuiyi wangkuiyi mentioned this pull request Apr 8, 2018
Closed
@wangkuiyi
Copy link
Collaborator Author

I am suffering from the CI fails on this problem: #9071 (comment)

putcn
putcn approved these changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@putcn putcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@putcn putcn merged commit 2bc5b08 into PaddlePaddle:develop Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@putcn putcn putcn approved these changes

@gangliao gangliao Awaiting requested review from gangliao

@chengduoZH chengduoZH Awaiting requested review from chengduoZH

Assignees
No one assigned
Labels
Code Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangkuiyi @putcn