[WIP] Add all gather op and all reduce op #9713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
feature/add_all_reduce_and_all_gather_op
branch
from
7f595aa
to
22a064a
Compare
chengduoZH
force-pushed
the
feature/add_all_reduce_and_all_gather_op
branch
from
22a064a
to
231a219
Compare
|
Briefly discussed. Customized gather and reduce might allow us to fully overlap computation with memcpy. It also allows us to do customized sparse gradient aggregation. Nice! |
|
I do not believe that implementation is faster than NCCL, especially for dense parameters. Also, I think |
chengduoZH
force-pushed
the
feature/add_all_reduce_and_all_gather_op
branch
2 times, most recently
from
f78783d
to
5f337c9
Compare
chengduoZH
force-pushed
the
feature/add_all_reduce_and_all_gather_op
branch
from
5f337c9
to
1e29c2e
Compare
|
The PR did not reach the expectation, so it can be turned off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempt to resolve the sparse gradient on multi-cards.