Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test_conv2d_op when compile without cuda #9698

Merged
merged 1 commit into from
Apr 7, 2018
Merged

fix test_conv2d_op when compile without cuda #9698

merged 1 commit into from
Apr 7, 2018

Conversation

lgone2000
Copy link
Contributor

fix #9697

wangkuiyi
wangkuiyi approved these changes Apr 7, 2018
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lgone2000 !

chengduoZH
chengduoZH reviewed Apr 7, 2018
View reviewed changes
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
Could you please also modify test_conv3d_op, test_pool2d_op and test_pool3d_op?

@wangkuiyi wangkuiyi merged commit 6ba2625 into PaddlePaddle:develop Apr 7, 2018
@lgone2000
Copy link
Contributor Author

I'll do it later

@lgone2000 lgone2000 mentioned this pull request Apr 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengduoZH chengduoZH chengduoZH left review comments

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_conv2d_op can't pass unittest when compile without cuda
3 participants
@lgone2000 @wangkuiyi @chengduoZH